PR summary 650e8b8fb3

Import changes for modified files

No significant changes to the import graph

Declarations diff

+ E

## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

./scripts/technical-debt-metrics.sh pr_summary

I'd suggest the following:

• Don't use N : ℕ+, but instead N : ℕ with a [NeZero N] instance. This requires one tiny change elsewhere, in isBoundedAtImInfty_eisensteinSeries_SIF, and everything else just works. (You can get a proof of positivity of N with NeZero.pos N.) Then you can just write ZMod 1, not the ugly and tedious-to-type ZMod ((1 : ℕ+) : ℕ).
• Since standardCongruenceCondition is defined to be 0, why not just skip defining it and just write 0 directly (letting it be coerced implicitly to a vector)? Note that mathlib can synth a subsingleton instance for Fin 2 → ZMod 1, while it apparently can't for ZMod ((1 : ℕ+) : ℕ).
• mod_cast hk achieves the same as by omega but it's more obvious to the reader what it's doing.

BTW, I think the review process will go quicker if you make your PR's a little larger than this; I tend to aim for 200-500 lines at a time. If you slice things too finely it makes more work both for reviewers + for yourself (more tedious git merging).

Thanks! Yes this one was a bit too short I agree.

LGTM now

maintainer merge

🚀 Pull request has been placed on the maintainer queue by loefflerd.

Thanks!

bors merge

Canceled.

Ouch, there's a weird build glitch in a file entirely unrelated to the PR; we should have a linter banning simp says.

@riccardobrasca can you do a bors delegate?

Thanks!

bors d+

✌️ CBirkbeck can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Merging master should probably fix the problem.

bors r+

Pull request successfully merged into master.

Build succeeded:

• CI Success